Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Nullable Fields During Folder Changes Check #13937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check Nullable Fields During Folder Changes Check #13937

wants to merge 1 commit into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 4, 2024 •
edited
Loading

  • Tests written, or not not needed

How to Test?

  1. Place a debugger in the checkForChanges() function.
  2. Try syncing both a changed and an unchanged folder; the debugger should hit the selected line, and the correct result should be returned.

@alperozturk96 alperozturk96 linked an issue Nov 4, 2024 that may be closed by this pull request
NPE: Attempt to invoke virtual method 'java.lang.String com.owncloud.android.datamodel.OCFile.getEtag()' via checkForChanges #13784
Open
@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Could you check the returned ResultCodes? Are they correct? Maybe some other result codes can suit better.

@alperozturk96 alperozturk96 changed the title BugFix - Check Nullable Fields During Folder Changes Check Check Nullable Fields During Folder Changes Check Nov 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Codacy

Lint

TypemasterPR
Warnings59134
Errors33

SpotBugs

CategoryBaseNew
Bad practice6565
Correctness6263
Dodgy code299299
Experimental11
Internationalization77
Malicious code vulnerability11
Multithreaded correctness66
Performance5353
Security1818
Total512513

Lint increased!

SpotBugs increased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
1 participant
@alperozturk96